Code cleanup of Hearing module

[jokoho48]

Code cleanup of Hearing module.

[PabstMirror]

This has a string inside of a if statement and no comparison to _weapon

[jokoho48]

oh yeah i miss that

[PabstMirror]

I tested the call/switch statements, I'm not seeing much benifit in bis's benchmark:

_firer = player;
_weapon = (handgunWeapon player);
_silencer = switch (_weapon) do {
    case (primaryWeapon _firer) : {(primaryWeaponItems _firer) select 0};
    case (secondaryWeapon _firer) : {(secondaryWeaponItems _firer) select 0};
    case (handgunWeapon _firer) : {(handgunItems _firer) select 0};
    default {""};
};
0.0117188 ms
0.0116699 ms

_firer = player;
_weapon = (handgunWeapon player);
_silencer = call {
    if ((primaryWeapon _firer) == _weapon) exitWith {(primaryWeaponItems _firer) select 0};
    if ((secondaryWeapon _firer) == _weapon) exitWith {(secondaryWeaponItems _firer) select 0};
    if ((handgunWeapon _firer) == _weapon) exitWith {(handgunItems _firer) select 0};
    ""
};
0.012207 ms
0.0123047 ms

[jokoho48]

yeah right see what you mean hmm ok i try it self

[thojkooi]

In fact looking at those tests, it seems to be faster to stick with the switch. It also is easier to read/understand without having to take a closer look imo.

[jokoho48]

but if you use a swtich True call if exitWith is faster

[PabstMirror]

looks good, merging before looking at #1988 to avoid conflicts.