Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse List Common Function #2257

Merged
merged 12 commits into from
Oct 18, 2015
Merged

Parse List Common Function #2257

merged 12 commits into from
Oct 18, 2015

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Aug 24, 2015

Used for parsing strings in modules, has params for optional remove whitespace (default is trim) and to check for object existence. Rerouted part of assignObjectsInList through this as well.

@jonpas jonpas changed the title Added Parse List Common Function Parse List Common Function Aug 24, 2015
@MikeMatrix
Copy link
Contributor

👍

@jokoho48 jokoho48 added kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:** labels Aug 24, 2015
@jonpas
Copy link
Member Author

jonpas commented Aug 31, 2015

Status? As soon as this gets merged (or closed) I'll replace string operations with new commands.

@commy2
Copy link
Contributor

commy2 commented Aug 31, 2015

I'd say something, but I have no idea at all what this does.

@jonpas
Copy link
Member Author

jonpas commented Aug 31, 2015

It parses modules which take strings, (eg. list of medical vehicles or list of repair facilities), checks for nil, removes or trims whitespace (all parameters). It is used in all modules that can take a list and the code was duplicated in each of them, this simply makes one function that all modules can use. It can of course be used for something else than modules, hence why it's in common.

@thojkooi
Copy link
Contributor

thojkooi commented Sep 1, 2015

I wonder if modules isn't a better location for this.

@jonpas
Copy link
Member Author

jonpas commented Sep 1, 2015

I'd say no, it doesn't take module logic, it can be used for anything else that requires parsing string lists.

@jonpas
Copy link
Member Author

jonpas commented Sep 9, 2015

Merge conflicts resolved.

Conflicts:
	addons/common/functions/fnc_assignObjectsInList.sqf
@jonpas
Copy link
Member Author

jonpas commented Sep 22, 2015

Status?

@commy2
Copy link
Contributor

commy2 commented Sep 22, 2015

I still have no idea what this does, haha.

@jokoho48
Copy link
Member

it combine a function that used in closly every module and is written there any time seprate and this combine this

@commy2
Copy link
Contributor

commy2 commented Sep 22, 2015

👍 Merge then if anyone can confirm this works.

@jonpas
Copy link
Member Author

jonpas commented Sep 22, 2015

If someone else can give it a test that would be great!

@thojkooi thojkooi added this to the 3.4.0 milestone Sep 22, 2015
@jonpas
Copy link
Member Author

jonpas commented Sep 28, 2015

Self-note #2565

Conflicts:
	addons/medical/functions/fnc_moduleAssignMedicalVehicle.sqf
@jonpas
Copy link
Member Author

jonpas commented Sep 28, 2015

Added vehicle support from #2565 for synchronizedObjects with an optional parameter.

thojkooi added a commit that referenced this pull request Oct 18, 2015
Parse List Common Function
@thojkooi thojkooi merged commit 76efdbc into acemod:master Oct 18, 2015
@jonpas jonpas deleted the parseList branch October 18, 2015 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants