make use of new getAllHitpointsDamage command #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions about hitpoints
commy2
added
kind/enhancement
commy2
changed the title
| @@ -215,6 +215,7 @@ PREP(getConfigGunner); | |||
| PREP(getConfigCommander); | |||
| PREP(getHitPoints); | |||
| PREP(getHitPointsWithSelections); | |||
| PREP(getSelectionsWithoutHitPoints); | |||
There was a problem hiding this comment.
A better name might be getSelections so it would mirror getHitPoints, that automatically implies it's without anything else.
There was a problem hiding this comment.
But those are only the selections that don't have any hitpoint assigned, not all damageable selections.
There was a problem hiding this comment.
Why not just make them into one function anyways and parameterize it?
There was a problem hiding this comment.
Why not just make them into one function anyways and parameterize it?
It's a completely different approach as getHitpoints. I personally don't like the overhead that comes with checking optinal parameters when nothing but one line is shared between both functions.
commy2
added a commit
that referenced
this pull request
Sep 21, 2015
common code cleanup part 10, close #2319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.