Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove BI blood overlay #2331

Merged
merged 1 commit into from
Jun 11, 2016
Merged

remove BI blood overlay #2331

merged 1 commit into from
Jun 11, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Aug 31, 2015

On the medical-adjustments branch the wound visuals on the uniform are flickering when shooting someone, because some hitpoints are reset for one frame.
I was told that this was added to prevent some BI effects when getting hit by a bullet.
No idea which effects exactly, but if it's only the blood fx, then this PR does it by config and not by scripting which is the prefered way imo.

@commy2 commy2 added this to the 3.4.0 milestone Aug 31, 2015
@thojkooi thojkooi self-assigned this Sep 1, 2015
@gienkov
Copy link
Contributor

gienkov commented Sep 1, 2015

👍

@thojkooi
Copy link
Contributor

thojkooi commented Sep 5, 2015

This does not seem to work. I still had the damage effects.

@commy2
Copy link
Contributor Author

commy2 commented Sep 5, 2015

I have no idea how to remove the blood vignette.

* 0: Effect multiplier <NUMBER>
*
* Return Value:
* nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None

@thojkooi
Copy link
Contributor

@commy2 what is the status on this? I don't think it removes the blood overlay anymore, but instead fixes the blood effects, right?

@commy2
Copy link
Contributor Author

commy2 commented Oct 11, 2015

This does:

  • remove blood texture when being hit
  • remove other permanent blood texture when being damaged
  • adds a equivalent to BIS_fnc_bloodEffect that uses unsheduled environment and therefore works way better

It does not:

  • remove the permant pp-effect while being damaged. It's a ColorCorrections type effect I think with unknown origin, possibly hard coded. No idea how we would remove that.

@commy2
Copy link
Contributor Author

commy2 commented Oct 11, 2015

I think it could be merged, but you said:

This does not seem to work. I still had the damage effects.

No idea what you mean by that, except that color correction that looks similar to a vignette, but isn't one technically. Possibly provide a screenshot if I missed something?

@gienkov
Copy link
Contributor

gienkov commented Oct 11, 2015

Its that "red flashing" you get in vanilla A3 which is incredibly annoying.
I think there is BI function that regulates intensity of this piece of sh*t.
11 paź 2015 3:21 PM "commy2" notifications@github.com napisał(a):

I think it could be merged, but you said:

This does not seem to work. I still had the damage effects.

No idea what you mean by that, except that color correction that looks
similar to a vignette, but isn't one technically. Possibly provide a
screenshot if I missed something?


Reply to this email directly or view it on GitHub
#2331 (comment).

@thojkooi thojkooi modified the milestones: 3.4.0, 3.5.0 Nov 28, 2015
@thojkooi thojkooi modified the milestones: 3.6.0, 3.5.0 Feb 20, 2016
@thojkooi
Copy link
Contributor

thojkooi commented May 8, 2016

Going to try and get this in today.

@commy2 commy2 force-pushed the 323bloodyoverlay branch from 9f61926 to 0829f18 Compare June 6, 2016 12:05
@thojkooi thojkooi merged commit 7f92577 into master Jun 11, 2016
@thojkooi thojkooi deleted the 323bloodyoverlay branch June 11, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants