Add Keybinding for Drop in Dragging #2333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokoho48
added
kind/enhancement
| false | ||
| }, | ||
| { false }, | ||
| [0, [false, false, false]] |
There was a problem hiding this comment.
This is an optional parameter according to this
There was a problem hiding this comment.
and so i am sure that this have no assign
There was a problem hiding this comment.
Default is [-1, [false, false, false]] anyways. Having this there is imo more confusing, since you don't omit setting the default itself, making it feel like this is actually a value to be considered (So it has a default binding).
|
I like it. |
|
👍 |
|
I'd say we close this in favour of #2598 |
|
Drop can now be done with LMB which makes this obsolete. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Keybinding for Drop in Dragging
based on #2284 (comment) Idea