Code cleanup Backpacks #2607
Merged
Code cleanup Backpacks #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,3 @@ | |||
| #include "script_component.hpp" | |||
|
|
|||
| ["backpackOpened", DFUNC(backpackOpened)] call EFUNC(common,addEventHandler); | |||
| ["backpackOpened", {_this call FUNC(backpackOpened)}] call EFUNC(common,addEventHandler); | |||
There was a problem hiding this comment.
I've seen you do this in multiple PR's now, and understanding the reason behind this it is a good thing to do.
However I feel like this is fixing the symptoms rather the issue. The issue being, that addEventHandler can only create copies of code, instead of being also be able to reference to existing variables.
Fixing this at the source of the problem might be the better approach.
There was a problem hiding this comment.
I'll take a look at that. But in a later PR to not cause conflicts now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.