Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup WeaponSelect #2626

Merged
merged 6 commits into from
Sep 28, 2015
Merged

Code Cleanup WeaponSelect #2626

merged 6 commits into from
Sep 28, 2015

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 27, 2015

I hope this can be drastically simplyfied by using this handy new command:
https://community.bistudio.com/wiki/currentThrowable

ref: #2241

@commy2 commy2 added status/WIP kind/cleanup Release Notes: **CHANGED:** labels Sep 27, 2015
@commy2 commy2 added this to the 3.4.0 milestone Sep 27, 2015
@commy2 commy2 self-assigned this Sep 27, 2015
@commy2
Copy link
Contributor Author

commy2 commented Sep 27, 2015

158 additions and 567 deletions
7 functions less

All thanks to the new currentThrowable command. Now I can finally say that I'm fully satisfied with the technical aspects of the implementaion of grenade select. Thanks BI 🍌

@commy2 commy2 removed the status/WIP label Sep 27, 2015
@jonpas
Copy link
Member

jonpas commented Sep 27, 2015

Very nice!

commy2 added a commit that referenced this pull request Sep 28, 2015
@commy2
Merge pull request #2626 from acemod/340weaponselectcleanup
6289a0c 
Code Cleanup WeaponSelect
@commy2 commy2 merged commit 6289a0c into master Sep 28, 2015
@commy2 commy2 deleted the 340weaponselectcleanup branch September 28, 2015 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @jonpas