Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify frag config #2670

Merged
merged 2 commits into from
Nov 26, 2015
Merged

Simplify frag config #2670

merged 2 commits into from
Nov 26, 2015

Conversation

jokoho48
Copy link
Member

@jokoho48 jokoho48 commented Oct 3, 2015

No description provided.

@jokoho48 jokoho48 added kind/enhancement Release Notes: **IMPROVED:** config labels Oct 3, 2015
@jokoho48 jokoho48 added this to the 3.4.0 milestone Oct 3, 2015
@jonpas
Copy link
Member

jonpas commented Oct 3, 2015

Can't comment because the file is not shown, so here we go...

  • Indent everything between L28 and L79
  • Add a new line after L78
  • Separate L3 into 2 lines and entire first define to proper indentation, like that:
#define ACE_EXPLOSION_REFLECTION(range, hit)\
    class ace_explosion_reflection_##range##_##hit : ace_explosion_reflection_base {\
        indirectHitRange = range;\
        indirectHit = hit;\
        dangerRadiusHit = range*3;\
        suppressionRadiusHit = range*2;\
    };

thojkooi added a commit that referenced this pull request Nov 26, 2015
@thojkooi thojkooi merged commit 81ab280 into master Nov 26, 2015
@thojkooi thojkooi deleted the simplifyFragConfig branch November 26, 2015 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants