Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix that in UGV dont work speedLimiter #2884

Merged
merged 2 commits into from
Nov 29, 2015
Merged

fix that in UGV dont work speedLimiter #2884

merged 2 commits into from
Nov 29, 2015

Conversation

jokoho48
Copy link
Member

posible fix #2875

@jokoho48 jokoho48 added the kind/bug-fix Release Notes: **FIXED:** label Nov 26, 2015
private _connectedUAV = getConnectedUAV ACE_player;
private _uavControll = UAVControl _connectedUAV;
if ((_uavControll select 1) == "DRIVER") then {
if !(_connectedUAV isKindOf "UGV_01_base_F") exitWith {false};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No!!! I can't stand hardcoded classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we need a function in common, eg. EFUNC(common,isUAV).

The problem is UAVs are in 2 different sections, so they literally have 2 base classes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this case only need UGVs and not support UAVs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isUav = 1;

Not many UAV's that are also a car/tank; so hard coded isn't terrible (this is a pretty odd edge case)

@commy2 commy2 added this to the 3.4.0 milestone Nov 27, 2015
@gienkov
Copy link
Contributor

gienkov commented Nov 27, 2015

👍

thojkooi added a commit that referenced this pull request Nov 29, 2015
fix that in UGV dont work speedLimiter
@thojkooi thojkooi merged commit 02eee05 into master Nov 29, 2015
@jokoho48 jokoho48 deleted the speedLimiterUGVFix branch November 29, 2015 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use speed limiter on UGV
6 participants