Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optics - Don't modify camera for ThreeDen Editor #3041

Merged
merged 2 commits into from
Dec 17, 2015
Merged

Conversation

PabstMirror
Copy link
Contributor

Fix broken ThreeDen Camera when returning to editor from preview.
PIP will still work in preview.
Will have to take a look at 1.56 RC to see if command exists and eventually cleanup.

Fix broken ThreeDen Camera when returning to editor from preview.
PIP will still work in preview.
Will have to take a look at 1.56 RC to see if command exists and
eventually cleanup.
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Dec 16, 2015
@PabstMirror PabstMirror added this to the 3.4.2 milestone Dec 16, 2015
@@ -6,6 +6,12 @@ if (!hasInterface) exitWith {};
GVAR(camera) = objNull;

0 = 0 spawn {
// Workarround for the ThreeDen Editor Camera
//ToDo: verify if command will exist in 1.56 release
if (((productVersion select 2) >= 155) && {is3DEN}) exitWith {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe !isNil {is3DEN} instead? Just in case they don't finish the editor for 1.56.
Or: "n:is3den" in supportInfo "n:*"

@jokoho48
Copy link
Member

👍 work fine

PabstMirror added a commit that referenced this pull request Dec 17, 2015
Optics - Don't modify camera for ThreeDen Editor
@PabstMirror PabstMirror merged commit d8d3c14 into release Dec 17, 2015
@PabstMirror PabstMirror deleted the fixThreeDenCam branch December 17, 2015 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants