Add support for non local Zeus RC in common-isPlayer #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. |
| ACE_LOGINFO_3("[%1] DC - Was Zeus [%2] while controlling unit [%3] - manually clearing `bis_fnc_moduleRemoteControl_owner`", [_x] call FUNC(getName), _dcPlayer, _x); | ||
| _x setVariable ["bis_fnc_moduleRemoteControl_owner", nil, true]; | ||
| }; | ||
| } count (curatorEditableObjects _zeusLogic); |
There was a problem hiding this comment.
iirc there has been a discussion in slack that we always should return something in count loops. nil, false etc...
There was a problem hiding this comment.
This will implicitly return nil, though it is probably good practise to do that explicitly
PabstMirror
added a commit
that referenced
this pull request
Dec 31, 2015
Add support for non local Zeus RC in common-isPlayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for non-local zeus remote controlled units in isPlayer.
So this command will now work consistantly on any machine.
Uses a BIS setVar from the zeus module, had to add a disconnect handler to clear variable.
Slightly faster as well.
I think this is important for consistent behavior, for example wind deflection does:
if (!([_unit] call EFUNC(common,isPlayer))) exitWith {false};Right now only the zeus would run the code, so the bullet's path won't appear consistent with it's effects.