Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitting Cleanup #3092

Merged
merged 2 commits into from
Dec 31, 2015
Merged

Sitting Cleanup #3092

merged 2 commits into from
Dec 31, 2015

Conversation

PabstMirror
Copy link
Contributor

@jonpas - Minor Cleanup of sitting module

  • Add modern privates
  • Don't add actions, canInteractWith condition, or EH if not enabled

@PabstMirror
Sitting Cleanup
d372111 
- Add modern privates
- Don't add actions, canInteractWith, or EH if not enabled
@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Dec 30, 2015
@PabstMirror PabstMirror added this to the 3.4.2 milestone Dec 30, 2015
jonpas
jonpas reviewed Dec 30, 2015
View reviewed changes
addons/sitting/XEH_clientInit.sqf
["SettingsInitialized", {
TRACE_1("SettingInit", GVAR(enable));

//If not enabled, dont't add CanInteractWith Condition or event handlers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't

@jonpas
Copy link
Member

jonpas commented Dec 30, 2015

Looks good! 👍

PabstMirror added a commit that referenced this pull request Dec 31, 2015
@PabstMirror
Merge pull request #3092 from acemod/minorSittingCleanup
62a9475 
Sitting Cleanup
@PabstMirror PabstMirror merged commit 62a9475 into release Dec 31, 2015
@PabstMirror PabstMirror deleted the minorSittingCleanup branch December 31, 2015 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@PabstMirror @jonpas