Explosive events, fix #3104

[bux]

When merged this pull request will:

• add 2 new events: defuse and explodeOnDefuse
• add _unit to place event

Can be tested with:

["ace_explosives_place", {
    hint format ["Placed:\nexpl: %1\nunit: %2", _this select 0, _this select 3];
}] call ace_common_fnc_addEventHandler;

["ace_explosives_defuse", {
    hint format ["Defused:\nexpl: %1\nunit: %2", _this select 0, _this select 1];
}] call ace_common_fnc_addEventHandler;

["ace_explosives_explodeOnDefuse", {
    hint format ["ExplodedOnDefuse:\nexpl: %1\nunit: %2", _this select 0, _this select 1];
}] call ace_common_fnc_addEventHandler;

[nicolasbadano]

👍 Looks good

[jonpas]

👍

[Cuel]

shouldn't it be placed/defused/explodedOnDefuse ? 😄

[CorruptedHeart]

It appears some listenable events are listed here this would probably need to be added there.

But there is both past tense and current tense words used in the events listed there so probably either naming scheme is fine but we might want to be consistent at some point.

[jonpas]

@CorruptedHeart This list is generated with a script, events should be added to module-specific framework page, they get pulled into one big list on events framework page then.

[CorruptedHeart]

Alright, I guess we still need to have a discussion about whether to keep them named like they are now or past tense.

[jonpas]

I was always thinking that those that are there to signal that something happened (listenable) are named in past tense, and those that can be used to perform a certain action (callable) are like those in this PR.

[Cuel]

Agree with @jonpas.
Furthermore why not throw a "ace_explosives_detonated" in? I was just looking for that

[Bummeri]

Is it possible to provide that event that @Cuel was speaking about?

[nicolasbadano]

Is it possible to provide that event that @Cuel was speaking about?

It would be tricky, cause it would work with explosives detonated by remote control, but not for those that explode because of proximity, being damaged, etc. IMO it's not worth it with this limitations.