remove deprecated functions #3131
Conversation
| @@ -20,6 +20,8 @@ | |||
| */ | |||
| #include "script_component.hpp" | |||
|
|
|||
| ACE_DEPRECATED("ace_common_fnc_execRemoteFnc","3.6.0","ace_common_fnc_globalEvent"); | |||
There was a problem hiding this comment.
Search "execRemoteFnc" (59 hits in 44 files)
3.6 might be too close?
There was a problem hiding this comment.
Maybe. The goal to replace it with events was made a long time ago though.
There was a problem hiding this comment.
I'd say 3.6 is far enough, looking at previous releases it's quite some time between minor (eg. 3.4 -> 3.5) version updates. I think it's safe.
There was a problem hiding this comment.
While I agree with you @commy2, we should go with 2 updates before a deprecated function is removed. Target 3.7.0 for removal of the execRemoteFnc function - we should get rid of all the usages within ACE in 3.5.0 however.
There was a problem hiding this comment.
execRemoteFnc is used in some recently deprecated functions like fnc_setCaptivityStatus.sqf, which we have to support until 3.6.0. Therefore, I think we should keep at least those references past 3.5.0 to avoid having to rewrite those functions.
Remove functions the second update after deprecation.
Remove functions the second update after deprecation.
|
We will merge this when we start our release proces for 3.5.0. |
No description provided.