Restart specatator display if player in unitList #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible fix for #2677
|
Good catch, I'm thinking about reducing the delay between list updates so might remove the display restart in a later iteration. |
|
If there is a specific order to invoking those commands to work safely, the documentation should reflect that. Or, have a third function that executes the 2 functions properly from one call. |
|
I mean...the whole point of this PR is that there isn't a specific order 😛 |
|
Merge? |
kymckay
added a commit
that referenced
this pull request
Jan 19, 2016
Restart specatator display if player in unitList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #2677
I think the core problem is that voiperr's demo mission does setSpectator before calling stage.
SetSpectator updates the unitList that has the player in it.
This PR is really just a bandAid that restarts the display when they are called out of order.