replace filter and map with select and apply #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }] call EFUNC(common,filter); | ||
| } count units _x; | ||
| (side _x == _playerSide) && _anyPlayers > 0 | ||
| }; // @todo, simplify this |
|
Should we also add other implementations that could use select or apply to this PR or do you want to keep it for only where the functions are replaced? |
|
Feel free to add more of these to this PR. I was just replacing the obvious uses of the functions with it for now, but there are certainly more places (that currently use forEachIndex for example) that could benefit from these. |
commy2
added a commit
that referenced
this pull request
Feb 18, 2016
replace filter and map with select and apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.