Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bodyBags vehicles that can carry respawning players #3316

Closed
wants to merge 2 commits into from

Conversation

PabstMirror
Copy link
Contributor

Fix #1301

Can bag re-spawning players
Can still access inventory of body
Can still track original body object

Dead bodies are odd, but this seems to be working fine.

  • setPos on dead bodies seems to need to be called where local
  • moveInX works on bodies, but moveOut doesn't, so there still is no way to get a body out of a bag

Can carry respawning players
Can still access inventory of body
Can still track body object
@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** needs review labels Feb 14, 2016
@PabstMirror PabstMirror added this to the 3.5.0 milestone Feb 14, 2016
@nicolasbadano
Copy link
Contributor

Morbid bycicle ❤️

@commy2
Copy link
Contributor

commy2 commented Feb 14, 2016

The class name ACE_bodyBagObject is infuriating.

@thojkooi
Copy link
Contributor

This is an interesting approach. 👍 I didn't notice anything odd in the code. Has this been tested in MP?

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.5.0 Feb 17, 2016
@PabstMirror
Copy link
Contributor Author

Just very small scale local dedi.
I'm not sure about the effects of making these vehicle simulations.
There may be negative effects on something like a persistant mission with many bags and possibly having AI react to the object being a LandVehicle.

An alternate fix would be https://github.com/acemod/ACE3/compare/playerBodybags
which just moves the locked player bodies to a corner, hides them and then deletes when free. I actually feel that would be safer, but this would offer more features (like not deleting the body object and having access to inventory)

@thojkooi thojkooi modified the milestones: Backlog, Ongoing Feb 20, 2016
@PabstMirror PabstMirror closed this May 7, 2016
@thojkooi thojkooi deleted the bodyBagVeh branch June 16, 2016 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants