Fixed c4996 compiler warning/error due to use of strncpy and ace_clipboard memory leak #3331
Conversation
|
Looks good, extensions parse_imagepath and fcs both have the same problem |
|
Okay, patched every module using strcpy, strncpy or in clipboards case memcpy for strings. Didn't come across any code that looked like you could actually trigger an overflow which is good. |
|
Fixed some issues I spotted with the ace_clipboard implementation, such as using memory semantics meant for GMEM_MOVEABLE, and the heap memory not being cleaned up on failure and being allocated before the clipboard was ready to be used. |
|
|
||
| GlobalUnlock(hClipboardData); | ||
| #ifndef _WIN32 | ||
| EXTENSION_RETURN(); |
There was a problem hiding this comment.
Wouldn't the extension always return here before running the strcmp check?
There was a problem hiding this comment.
Only if the pre-processor definition _WIN32 is undefined, so basically only if compiled/used on linux. I was looking into getting clipboard content from x11 for ubuntu support, but im not sure where ACE is with linux support.
There was a problem hiding this comment.
Yeah, sorry, I missed the n
looterz
changed the title
|
This looks good, just needs some formatting changes and the merge conflict resolved. Once that is done, we will merge it 👍 Thanks @looterz I wil see if I can get around to do that later today. |
Noticed the funny comment and thought I would submit a PR, strncpy_s with the _TRUNCATE flag will also ensure that the string is null-terminated whether it fits or not. Looks like ballistics and some other extensions make heavy use of strncpy as well but don't disable the warning, which on some compilers might cause an error.