Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better flash effects #3346

Merged
merged 5 commits into from
Feb 20, 2016
Merged

Better flash effects #3346

merged 5 commits into from
Feb 20, 2016

Conversation

nicolasbadano
Copy link
Contributor

When merged this pull request will:

  1. Make sure the light effect is rendered even if the grenade explodes further than 20m from the player. This provides much better feedback that the grenade exploded, even if the player is not affected.
  2. Increase the amount of hearing damage from the bang. Should work nicely with the new hearing overhaul.
  3. Increase the maximum range for blinding effect to 25m, but with a higher-than-linear falloff. Close M84 Flashbang has low effect radius #1539.
  4. Make units heavily affected by the blast turn away from the light, as per @bux578 request.

Bottom line, this should improve both the UX of throwing flashbangs and their effectiveness.

@bux
Copy link
Member

bux commented Feb 19, 2016

👍

How strong will AI be affected by this?
I think AI could need some more love concerning flashbangs

@nicolasbadano
Copy link
Contributor Author

How strong will AI be affected by this?

I didn't change anything for AI, except for rotating them away. What are you thinking should be done?

@bux
Copy link
Member

bux commented Feb 19, 2016

I just tested it. The rotating away is very welcome. Good job.

@bux
Copy link
Member

bux commented Feb 19, 2016

@nicolasbadano
Copy link
Contributor Author

Nice:

1- the last one shot you because he was too far from the grenade. Maybe we should increase the range another 5m?

2- The flash of light is visible through the wall due to arma awfull illumination technology. Hopefully if they ever change to a deferred technique (enfusion?) that should be fixed.

@bux
Copy link
Member

bux commented Feb 19, 2016

Question: The rotation is 180° from current direction? Or 180° from the direction to the flashbang?

If it is from current direction, AI units that look through a window and have the door behind them would rotate towards the door.

@nicolasbadano
Copy link
Contributor Author

The rotation is 180° away from the grenade:

_x setVectorDir ((getPosASL _x) vectorDiff _grenadePosASL);

@bux
Copy link
Member

bux commented Feb 19, 2016

Maybe we should increase the range another 5m

I'll ask my BW aquaintance.

@jokoho48
Copy link
Member

@esteldunedain can you add A Animation for that like in the mod: http://www.armaholic.com/page.php?id=21139

this is a Vanilla Animation if i remeber right

edit: found it _unit switchmove "acts_CrouchingCoveringRifle01";

@nicolasbadano
Copy link
Contributor Author

@esteldunedain can you add A Animation for that like in the mod: http://www.armaholic.com/page.php?id=21139

Looks cool, but I don't what animation is that. @CorruptedHeart, are you the author?

@bux
Copy link
Member

bux commented Feb 19, 2016

A M84 should totally cover this room.

@nicolasbadano
Copy link
Contributor Author

A M84 should totally cover this room.

It should cover it now

@bux
Copy link
Member

bux commented Feb 19, 2016

👍 merge merge merge 😄

thojkooi added a commit that referenced this pull request Feb 20, 2016
@thojkooi thojkooi merged commit fbcfbb9 into master Feb 20, 2016
@thojkooi thojkooi deleted the betterFlashEffects branch February 20, 2016 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants