Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace some ace_common_fnc_X with CBA_fnc_X #3366

Merged
merged 5 commits into from
Feb 22, 2016
Merged

replace some ace_common_fnc_X with CBA_fnc_X #3366

merged 5 commits into from
Feb 22, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 20, 2016

When merged this pull request will:

  1. replace ace_common_fnc_canUseWeapon with CBA_fnc_canUseWeapon
  2. replace ace_common_fnc_selectWeaponMode with CBA_fnc_selectWeapon

@commy2 commy2 added the kind/cleanup Release Notes: **CHANGED:** label Feb 20, 2016
@commy2 commy2 self-assigned this Feb 20, 2016
@PabstMirror
Copy link
Contributor

Public: Yes - so we might want to do the deprecated thing?

@thojkooi
Copy link
Contributor

Yes, deprecate our version.

@commy2 commy2 changed the title relace ace_common_fnc_canUseWeapon with CBA_fnc_canUseWeapon relace some ace_common_fnc_X with CBA_fnc_X Feb 20, 2016
@nicolasbadano
Copy link
Contributor

CBA_fnc_stealACEFunctions :)

Bonus points if you cache CBA_fnc_canUseWeapon

@bux bux changed the title relace some ace_common_fnc_X with CBA_fnc_X replace some ace_common_fnc_X with CBA_fnc_X Feb 21, 2016
commy2 added a commit that referenced this pull request Feb 22, 2016
@commy2
Merge pull request #3366 from acemod/cbacanuseweapon
dc16136 
replace some ace_common_fnc_X with CBA_fnc_X
@commy2 commy2 merged commit dc16136 into master Feb 22, 2016
@commy2 commy2 deleted the cbacanuseweapon branch February 22, 2016 15:28
@commy2 commy2 added this to the 3.5.0 milestone Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@commy2 @PabstMirror @thojkooi @nicolasbadano