Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Self Interact Menu from bugging out during animations #3445

Merged
merged 2 commits into from
Feb 27, 2016

Conversation

nicolasbadano
Copy link
Contributor

Issues:

These is about two usability problems that happen in the IM while self interacting:

  1. There are corner cases in which the interact menu collapses back to the action point while you try to select subactions while the expand animation is not complete. This makes lower speed animations a pain to use, specially if your are trying to be fast. This is visible in the video starting at time=6s
  2. For slow animation speeds, the "Self Interact" opion doesn't auto expand instantly. That leads to the menu not expanding at all if you try to move the mouse to the right too quickly, That is visible in the video multiple times

Video Before:
https://youtu.be/dM18AVn-Yw8
Video After:
https://youtu.be/a7LcJgGKKL0

The issues described above happen both for the 3d and the cursor modes of the menu. The video is made for 3d interaction because otherwise the cursor wouldn't be visible.

When merged this pull request will:

  1. Solve usability problem no.1. That is done by removing the code that collapses the menu if no action is selected and none is close to the cursor. That behaviour was outdated, and luckily only triggered on corner cases.
  2. Make @PabstMirror auto-expansion of the "Self Actions" base menu happen also for the slower animation speed. However, now the expand animation does play for all velocities, to better convey what is happening. This ensures the menu always expand, independently of how fast you move the mouse.

@nicolasbadano nicolasbadano added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Feb 27, 2016
@nicolasbadano nicolasbadano added this to the 3.5.0 milestone Feb 27, 2016
thojkooi added a commit that referenced this pull request Feb 27, 2016
Prevent Self Interact Menu from bugging out during animations
@thojkooi thojkooi merged commit f758a90 into master Feb 27, 2016
@thojkooi thojkooi deleted the preventSelfIMFromClosing branch February 27, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants