-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cancel (RMB) Action #3524
Fix Cancel (RMB) Action #3524
Conversation
Tested, seems to work fine. Tagging @commy2 for review. |
Okay this works as far as I can tell. previously these actions would only be called when the current action was active (e.g. carrying a ladder), but now all of them are executed when you RMB every time. e.g.: |
{_unit != ACE_player} || | ||
{!([_unit, objNull, ["isNotSwimming"]] call EFUNC(common,canInteractWith))} || | ||
{!(_magClassname in (magazines _unit))}) then { | ||
GVAR(placeAction) = PLACE_CANCEL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to remove this entire if statement, just the RMB part.
All of the other checks need to be run each frame in the PFEH so it will cancel if any of them happen.
e.g. if canInteractWith
is false, we need to cancel right away instead of waiting for RMB
I wonder if we could simplify the event handler code to a single common and then in all our placement blocks we do
|
there is no RMB release event though. |
I still think installing only one of this EH and launching an ACE event on RMB would be more efficient and easier to use. |
@esteldunedain I believe this is supposed to be solved with |
Yes. |
When merged this pull request will:
Untested (no access to Arma-capable machine at the moment)