Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty callback for hr adjustment #3527

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Fix empty callback for hr adjustment #3527

merged 1 commit into from
Mar 7, 2016

Conversation

PabstMirror
Copy link
Contributor

Fix #3526
Same issue as #3384

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Mar 3, 2016
@PabstMirror PabstMirror added this to the 3.5.1 milestone Mar 3, 2016
thojkooi added a commit that referenced this pull request Mar 7, 2016
Fix empty callback for hr adjustment
@thojkooi thojkooi merged commit 8946779 into master Mar 7, 2016
@thojkooi thojkooi deleted the fixHrCallbackVar branch March 7, 2016 11:51
@grester
Copy link

grester commented Mar 17, 2016

I know this has been closed but I'd like to point out that I'm not sure if this is indeed a bug or instead mod conflict. I say this because I have some simple missions where this error doesn't show up but I have some other missions with more scripts where the error does show up for all injections not just morphine. Just a heads up.

@commy2
Copy link
Contributor

commy2 commented Mar 17, 2016

Would be helpful to know which mod or mission causes the conflict.

@grester
Copy link

grester commented Mar 17, 2016

I have yet had success in tracking down what's causing it in my case. However I'd like to point out though that despite the error the injection is still applied successfully and it takes effect on both pulse and pressure. I've been editing my mission with only ACE, CBA and Eden Enchanced (this one isn't culprit as a simple mission done with it causes no problem). It's either a module or some disruptive script.

@PabstMirror
Copy link
Contributor Author

I have seen this with just CBA/ACE. I'm fairly sure it's a BIS thing.

x = missionNamespace getVariable ""
typeOf x = "EmptyDetector"

There are no medications that have a real callback, they all use hrCallback = "";
We could use something more explicit like `hrCallback = "#none", but I think this fix is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants