Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greatly improve the accuracy of the protractor display #3611

Merged
merged 1 commit into from
Mar 21, 2016
Merged

Greatly improve the accuracy of the protractor display #3611

merged 1 commit into from
Mar 21, 2016

Conversation

nicolasbadano
Copy link
Contributor

When merged this pull request will:

  • Improve accuracy of the protractor display. The movement is now linear with the sin of the angle instead of the angle itself, to account for the distorsion in the dial.
  • Close AB - Protractor : wrong indication #3606

For best results, the needle should match the center of the numbers in the dial.

20160320222308_1

@nicolasbadano nicolasbadano added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Mar 21, 2016
@nicolasbadano nicolasbadano added this to the 3.6.0 milestone Mar 21, 2016
nicolasbadano added a commit that referenced this pull request Mar 21, 2016
@nicolasbadano
Merge pull request #3611 from acemod/fixProtractor
faa2b26 
Greatly improve the accuracy of the protractor display
@nicolasbadano nicolasbadano merged commit faa2b26 into master Mar 21, 2016
@nicolasbadano nicolasbadano deleted the fixProtractor branch March 21, 2016 01:29
@commy2
Copy link
Contributor

commy2 commented Mar 21, 2016

math

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasbadano @commy2