Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove trench and continue digging trench actions #3612

Merged
merged 4 commits into from
May 7, 2016
Merged

Add remove trench and continue digging trench actions #3612

merged 4 commits into from
May 7, 2016

Conversation

SzwedzikPL
Copy link
Contributor

When merged this pull request will:

  • Add remove trench and continue digging trench actions
  • Add config vars to set time needed to dig or remove trench
  • Make digging trench ~50% longer
  • Remove trench or continue digging trench duration is based on config var and actual progress of trench "construction" e.g. if trench is finished in 50% removing this trench will take 50% of normal removal time.
  • Move trench placement data from preInit to object config
  • Remove grass behind the trench

Demo: https://www.youtube.com/watch?v=xqM6hCWkvLo

@nicolasbadano nicolasbadano added the kind/enhancement Release Notes: **IMPROVED:** label Mar 21, 2016
@nicolasbadano nicolasbadano added this to the 3.6.0 milestone Mar 21, 2016
@nicolasbadano nicolasbadano self-assigned this Mar 21, 2016
@nicolasbadano nicolasbadano mentioned this pull request Mar 21, 2016
7 tasks
displayName = CSTRING(ContinueDiggingTrench); \
condition = QUOTE([ARR_2(_target,_player)] call FUNC(canContinueDiggingTrench)); \
statement = QUOTE([ARR_2(_target,_player)] call FUNC(continueDiggingTrench);); \
showDisabled = 0; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showDisabled is obsolete. Should be removed.

@nicolasbadano
Copy link
Contributor

I'm not a huge fan of cutting the animation abruptly, but I do see the merit of doing it. I haven't yet seen the stuff in-game though.

@SzwedzikPL
Copy link
Contributor Author

I've moved placement data to config, maked _fnc_setPlacing a global setTrenchPlacement function, also little cleanup. @esteldunedain

@SzwedzikPL
Copy link
Contributor Author

  • Remove grass behind the trench

@thojkooi thojkooi merged commit f34d890 into acemod:master May 7, 2016
@SzwedzikPL SzwedzikPL deleted the trenchestweaks branch May 7, 2016 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants