Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverted gestures Stop and Freeze and minor gestures cleanup #3635

Merged
merged 5 commits into from
Apr 1, 2016
Merged

Fix inverted gestures Stop and Freeze and minor gestures cleanup #3635

merged 5 commits into from
Apr 1, 2016

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Mar 29, 2016

When merged this pull request will:

  • Fix Gesture Mixup #3543 - inverted "Stop" and "Freeze" ("Stop" will still be "Freeze" in prone, it's a vanilla animation we can't change)
  • Cleanup unused config
  • Improve stringtable (remove duplicate)
  • Replace DIK KeyCodes include and usage with decimal codes
  • Improve keybind adding and figuring out if it's a vanilla gesture or not
  • Add README.md and update author URL in config.cpp

@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** kind/cleanup Release Notes: **CHANGED:** kind/bug-fix Release Notes: **FIXED:** labels Mar 29, 2016
@jonpas jonpas added this to the 3.6.0 milestone Mar 29, 2016
@nicolasbadano
Copy link
Contributor

👍

1 similar comment
@jokoho48
Copy link
Member

jokoho48 commented Apr 1, 2016

👍

@jonpas jonpas merged commit 31953c5 into master Apr 1, 2016
@jonpas jonpas deleted the fixInvertedGestureStopFreeze branch April 1, 2016 19:30
PabstMirror added a commit that referenced this pull request Apr 21, 2016
@PabstMirror
Fix BIS gesture keybinds
4214e31 
- From #3635 - FUNC(playSignal) needs "BIgesture" prefix
- Interaction conditions are checked on parent, don't need on every
child
@PabstMirror PabstMirror mentioned this pull request Apr 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jokoho48 jokoho48

Labels
kind/bug-fix Release Notes: **FIXED:** kind/cleanup Release Notes: **CHANGED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jonpas @nicolasbadano @jokoho48