Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a local event when a weapon is jammed #3678

Merged
merged 2 commits into from
Apr 11, 2016

Conversation

Jsmuk
Copy link
Contributor

@Jsmuk Jsmuk commented Apr 11, 2016

When merged this pull request will:

  • Raise an event when a player's weapon jams.

This is a very minor (1 line!) change which will add an event upon weapon jamming to the public API. I personally have a use for it in an existing addon I am working on and I am sure that others may find it useful.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Apr 11, 2016
@PabstMirror PabstMirror added this to the 3.6.0 milestone Apr 11, 2016
@nicolasbadano
Copy link
Contributor

I think the event name is not ideal. As a rule of thumb, we are currently not prefixing the event names with the module name. Also we tend to use camelCase instead of snake_case.

Hence I propose changing the event name to weaponJammed.

@Glowbal, @bux, what do you think?

@Jsmuk
Copy link
Contributor Author

Jsmuk commented Apr 11, 2016

I was originally going to use weaponJammed but then I noticed an event I was already using (medical_onSetDead) so that confused me a little bit.

@nicolasbadano
Copy link
Contributor

I was originally going to use weaponJammed but then I noticed an event I was already using (medical_onSetDead) so that confused me a little bit.

Medical might be the only exception to the rules I posted 😄

@nicolasbadano nicolasbadano merged commit d57d6af into acemod:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants