Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up excessive whitespace #3751

Merged
merged 2 commits into from
May 4, 2016
Merged

Cleaned up excessive whitespace #3751

merged 2 commits into from
May 4, 2016

Conversation

BaerMitUmlaut
Copy link
Member

When merged this pull request will:

  • Remove unnecessary whitespace in blank lines, at the end of lines and sometimes within code too (where it didn't really benefit the clarity of the code).
  • Part of this is changing _this select ... to params in some AtragMX and Rangecard functions.

commy2
commy2 reviewed May 3, 2016
View reviewed changes
addons/atragmx/functions/fnc_calculate_solution.sqf
_twistDirection = _this select 19;
_latitude = _this select 20;
_directionOfFire = _this select 21;
params ["_scopeBaseAngle", "_bulletMass", "_boreHeight", "_airFriction", "_muzzleVelocity", "_temperature", "_barometricPressure", "_relativeHumidity", "_simSteps", "_windSpeed", "_windDirection", "_inclinationAngle", "_targetSpeed", "_targetRange", "_bc", "_dragModel", "_atmosphereModel", "_storeRangeCardData", "_stabilityFactor", "_twistDirection", "_latitude", "_directionOfFire"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest breaking up this very long line. There also is some strange white space in the middle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@commy2
Copy link
Contributor

commy2 commented May 3, 2016

very nice, neat and tidy

@BaerMitUmlaut BaerMitUmlaut added kind/enhancement Release Notes: **IMPROVED:** super anal labels May 3, 2016
@BaerMitUmlaut BaerMitUmlaut added this to the 3.6.0 milestone May 3, 2016
@BaerMitUmlaut BaerMitUmlaut added the kind/cleanup Release Notes: **CHANGED:** label May 3, 2016
@jonpas
Copy link
Member

jonpas commented May 3, 2016

All 👍 from me.

@thojkooi thojkooi merged commit 83a8c48 into master May 4, 2016
@thojkooi thojkooi deleted the wipeoutWhitespace branch May 4, 2016 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BaerMitUmlaut @commy2 @jonpas @thojkooi