Update coding guidelines #3785
Merged
Update coding guidelines #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor updates to our coding guidelines
|
|
||
| ### 6.5. Private Variables | ||
| All private variables shall be declared in a private array. | ||
| All private variables shall make use of the `private` keyword on initalization. When declaring a private variable before initalization, usage of the private array syntax is allowed. All private variables must be either initialized using the private key word, or declared using the private array syntax. |
There was a problem hiding this comment.
Or by using params I guess.
params is not exclusive to the functions arguments, but is sometimes also used in forEach loops (_x params [...]), so it might be worth noting.
There was a problem hiding this comment.
Or any array really. It's the same as EXPLODE_N_PVT macro was.
|
Added both the bit about params usage for arrays and fixed the missing |
|
👍 |
| Bad: | ||
| ```sqf | ||
| private _areAllAboveTen = true; // <- this is bad, because it can be initalized in the if statement | ||
| if (call FUNC(myCondition) then { |
There was a problem hiding this comment.
I didn't think it was worth to mention, but this line is also missing the same closing parenthesis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to our coding guidelines