Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction support to Motorcycle class #3787

Merged
merged 3 commits into from
May 14, 2016
Merged

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented May 12, 2016

When merged this pull request will:

  • Adds interaction support to Motorcycle class - for example CUP's M1030.

Known issues:

  • Wheel repairing does not work for CUP's M1030 because it is not PhysX configured and ACE repair component expects it to be.

I probably missed a bunch of stuff that should be added, name them please!

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label May 12, 2016
@jonpas jonpas added this to the 3.6.0 milestone May 12, 2016
@nicolasbadano
Copy link
Contributor

Looks good!

@@ -28,7 +28,11 @@ class Extended_InitPost_EventHandlers {
class Tank {
class ADDON {
init = QUOTE(_this call DFUNC(addRepairActions));
serverInit = QUOTE(_this call DFUNC(addSpareParts));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this for spare tracks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, removed it from the wrong class. 😆

@thojkooi thojkooi merged commit 36e4855 into master May 14, 2016
@thojkooi thojkooi deleted the motorcycleInteraction branch May 14, 2016 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants