Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip 'playerInventoryChanged' after firing #3793

Merged
merged 5 commits into from
May 18, 2016
Merged

skip 'playerInventoryChanged' after firing #3793

merged 5 commits into from
May 18, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 14, 2016

When merged this pull request will:

  • don't do 'playerInventoryChanged' just because ammo decreased after firing

ref: #3792

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label May 14, 2016
@nicolasbadano
Copy link
Contributor

@commy2, now that the playerInventoryChanged event performs well, it's probably the time to put it on CBA.

@commy2
Copy link
Contributor Author

commy2 commented May 14, 2016

@esteldunedain https://github.com/CBATeam/CBA_A3/pull/328/files

@commy2 commy2 self-assigned this May 18, 2016
@commy2 commy2 added this to the 3.6.0 milestone May 18, 2016
@commy2 commy2 merged commit e1403d5 into master May 18, 2016
@commy2 commy2 deleted the improvePlayerInventoryChanged branch May 18, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @nicolasbadano @PabstMirror