add a line to support JSRS Eden (getting rid of JSRS explosion sound … #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…effect)
JSRS Eden defines a SoundSetExplosion[] on ShellBase to define explosion sounds, which gives huntir unexpected exploding sound when used together. Adding SoundSetExplosion[] = {}; shall fix the problem.
jonpas
added
kind/enhancement
|
Thanks @gpgpgpgp |
|
Might be an idea to add a comment to that line stating why it's there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
…effect)
class ShellBase: ShellCore { SoundSetExplosion[] = {"DFyre_Shell_Exp_SoundSet","DFyre_Shell_Tail_SoundSet","DFyre_Explosion_Big_Debris_SoundSet"}; };JSRS DFyre Eden 1.2 defines a SoundSetExplosion[] on ShellBase to define explosion sounds, which gives HuntIR undesirable exploding sound when used together. Though it's a mod's fault, it's pretty much avoidable by applying minor changes to ACE 3. Adding SoundSetExplosion[] = {}; shall fix the problem.