Fix CfgPatches author/ is not a value

[jonpas]

When merged this pull request will:

• Fix 'Author/' is not a value #3839
• Convert all author[] to authors[] in all CfgPatches - CBA is changing that for compatibility with vanilla author
• Remove "ACE-Team" (strinbtabled) from authors[] in all CfgPatches - CBA will pull both author and authors[] together
• Add author with value "ACE-Team" (stringtabled) to all CfgPatches
• Add url with value `"http://ace3mod.com"`` to all CfgPatches
• Update blank component as well

Regex used

Converting author[] to authors[]:
Find:

author\[\] = {([\s\S]*?)};

Replace:

authors\[\] = {$1};

Adding author and url:
Find:

class CfgPatches([\s\S]*?);([\s]*?)authors\[\]

Replace:

class CfgPatches$1;\n        author = ECSTRING\(common,ACETeam\);$2authors\[\]
class CfgPatches$1;\n        url = "http://ace3mod.com";$2authors\[\]

[SzwedzikPL]

You can also add url = "http://ace3mod.com"; to have proper link in eden addons list

Ref: https://community.bistudio.com/wiki/CfgPatches

[bux]

Good job.

Though, the order of those entries is triggering me :)

Might be better:

author
authors[]
authorUrl
url

But it'd be just a cosmetic change.

And if no one is objecting, we could change authorUrl to http://ace3mod.com aswell.
multiple authors[] but only one authorUrl

[commy2]

remove it here or it will be shown twice

[jonpas]

Missed that one, nice spot.

[jonpas]

@bux578 I'd say we get rid of authorUrl and just keep url, @commy2 just pushed a change so url only will be shown if there are both (right?).

[commy2]

url will be shown in 2.4.1 CBA. It is also used in BIs shenanigans, so that's the way to go.

For bwc, CBA will fall back to authorURL, if url isn't there. Since that is not supported by BI, there is no reason to keep it.

I'd say replace all URLs with http://ace3mod.com instead of the github pages of the contributors. Possibly consider a macro (or add it to the VERSION_CONFIG macro)

[jonpas]

I totally forgot about that macro! Will put author and url there, remove authorUrl and leave authors[] as is. Actually that's not part of "version" so it doesn't make much sense.

[jonpas]

Done, also fuck line endings breaking my regex.

[bux]

How about making the URL into a stringtable entry or a macro?

[jonpas]

#define URL "http://ace3mod.com" or full #define URL url = "http://ace3mod.com";?

[bux]

I'd say first. So we could use it somewhere else.

[thojkooi]

I'd go for both.

#define WEB_URL "http://ace3mod.com/"
#define PBO_URL url = WEB_URL;

[bux]

good idea

[commy2]

I think the standard is to not have the ";" in the macro. Sorry for being picky.

[commy2]

Thanks!