Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic UI being overwritten on RscDiary unload #3920

Merged
merged 4 commits into from
Jun 18, 2016
Merged

Fix basic UI being overwritten on RscDiary unload #3920

merged 4 commits into from
Jun 18, 2016

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Jun 13, 2016

When merged this pull request will:

Todo:

  • Add condition source when false to hint
  • Add source to scripted element setting API

@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Jun 13, 2016
@jonpas jonpas added this to the 3.6.0 milestone Jun 13, 2016
@jonpas jonpas self-assigned this Jun 13, 2016
@jonpas jonpas changed the title Fix basic UI being overwritten on RscDiary close Fix basic UI being overwritten on RscDiary unload Jun 13, 2016
@commy2
Copy link
Contributor

commy2 commented Jun 14, 2016

Question. Does this mean that showHud in vanilla breaks every time you open the diary?
This would be really stupid and probably is a bug.

@jonpas
Copy link
Member Author

jonpas commented Jun 14, 2016

Apparently, I haven't tested myself in vanilla though. Map also uses RscDiary but that doesn't break it.

@commy2
Copy link
Contributor

commy2 commented Jun 14, 2016

I guess they use the command in their scripting for the diary?

@jonpas
Copy link
Member Author

jonpas commented Jun 14, 2016

Could be, can't check right now.

@jonpas jonpas removed the status/WIP label Jun 18, 2016
@jonpas jonpas merged commit ed15d99 into master Jun 18, 2016
@jonpas jonpas deleted the fixUi branch June 18, 2016 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants