Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added beautified component names #3960

Merged
merged 4 commits into from
Jun 20, 2016
Merged

Added beautified component names #3960

merged 4 commits into from
Jun 20, 2016

Conversation

BaerMitUmlaut
Copy link
Member

When merged this pull request will:

  • Add "beautified" component names
  • Change the component name macro
  • Fix the R3F compat component name (was BWA3_... before)
  • Make all component names lowercase only

@BaerMitUmlaut BaerMitUmlaut added the kind/enhancement Release Notes: **IMPROVED:** label Jun 20, 2016
@BaerMitUmlaut BaerMitUmlaut added this to the 3.6.0 milestone Jun 20, 2016
bux
bux reviewed Jun 20, 2016
View reviewed changes
addons/laserpointer/script_component.hpp
@@ -1,4 +1,5 @@
#define COMPONENT laserpointer
#define COMPONENT_BEAUTIFIED Laserpointer
Copy link
Member

@bux bux Jun 20, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laser Pointer

@commy2
Copy link
Contributor

commy2 commented Jun 20, 2016

First time using githubs online commit function
@BaerMitUmlaut I know it's hard for a German. One day they will learn the beauty of "zusammengesetzte Substantive".

@commy2 commy2 merged commit 653a371 into add_name Jun 20, 2016
@commy2 commy2 deleted the beautify-names branch June 20, 2016 10:38
@commy2 commy2 self-assigned this Jun 20, 2016
@jonpas jonpas mentioned this pull request Jul 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BaerMitUmlaut @commy2 @bux