Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert state checking to CBA playerEH #3973

Merged
merged 2 commits into from
Jun 22, 2016
Merged

Convert state checking to CBA playerEH #3973

merged 2 commits into from
Jun 22, 2016

Conversation

PabstMirror
Copy link
Contributor

For PR #3972

Still thinking about ace_playerInventoryChanged as right now this adds an extra call to FUNC(getAllGear) even when there are no listeners to the old event.

@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Jun 22, 2016
@PabstMirror PabstMirror added this to the Ongoing milestone Jun 22, 2016
@commy2
Copy link
Contributor

commy2 commented Jun 22, 2016

Still thinking about ace_playerInventoryChanged as right now this adds an extra call to FUNC(getAllGear) even when there are no listeners to the old event.

That doesn't worry me much. Current stable will do that every frame. Now the code won't be executed once for whole minutes. Events, yay.

@commy2 commy2 merged commit 047ac8c into cba-add-player-eh Jun 22, 2016
@commy2 commy2 deleted the eventWrappers branch June 22, 2016 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.
2 participants
@PabstMirror @commy2