Less aggressive overlap detection #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a fix for a side effect of #3342
I could not find the interaction point for the attached refuel nozzle.
In the cropped screenshot below, the refuel action would not be shown without this fix.
Interaction _sPos: [0.768666,0.525559,0.346336]
Refuel _sPos: [0.453124,0.457705,1.23955]
Delta: [-0.332239,-0.0714445,0.940485]
Distance2d: 0.322755
I think the vehicle's dynamic position is pushed so close to the player that it obscures things that it shouldn't.
This PR adds a 2nd requirement that the 2d screen pos distance needs to be small enough to make obscuring worthwhile.