Add reload mutex as canInteractWith condition

[commy2]

When merged this pull request will:

• adds !GVAR(isReloading) as condition for canInteract
• fixes Finger, AdvancedThrowing and Wipe Goggles ignore the reload mutex causing animation issues #3938

[nicolasbadano]

Hey, hold on. GVAR(isReloading) doesn't exist yet. It's currently called GVAR(ReloadMutex) and it is defined only on the gestures module. IMO it should be moved to common and renamed.

Also I wonder if it would be possible to set the variable from an AnimChanged EH instead of actionKeys for better reliability and joystick support.

[commy2]

AnimChanged or any other anim event handler don't trigger for gestures like the reload animations.

[nicolasbadano]

AnimChanged or any other anim event handler don't trigger for gestures like the reload animations.

Too bad; I was half expecting that reply though.

[commy2]

^ this is my version of at least supporting the modifier keys. Not finished, because:

_a = -1207959552; (_a + 1) in [_a]
-> true

FML

[jonpas]

Note: still needs additional canInteract checks on keybinds in all affected components.

[commy2]

No, it's a canInteractWith condition.

[jonpas]

Yes, whatever it's named. :P

[nicolasbadano]

Yes, whatever it's named. :P

Nah, @jonpas . @commy2 means that this works automatically, without having to add any extra checks

[commy2]

I think it's impossible to work with these offsets:
(-1207959552 + 32) + 1207959552
0

[nicolasbadano]

It's a precision issue; the numbers are being treated as floating point

[commy2]

Yeah, but that means that actionKeys cannot be used for this - at least not when we want to support modifier keys.

[nicolasbadano]

at least not when we want to support modifier keys.

Let's not support it. I doubt anyone uses one for reloading. We don't support joysticks anyway. The worst thing it can happen is that we retain current behaviour, right?

[jonpas]

Nah, @jonpas . @commy2 means that this works automatically, without having to add any extra checks

Ah, in that case - awesome!

[commy2]

I don't like how easy it is to trick the reload mutex.

Pressing R in a reloading incompatible stance starts the timer and when then actually doing the reloading, the isReloading value is reset mid reload.

[nicolasbadano]

Yeah, it's pretty unreliable stuff.

incompatible stance

Those can be detected from config I guess, right?

[PabstMirror]

Current interaction conditions take args [_player, _target],
so you could do something like check if another player can interact with you.

This new condition would only be valid for ACE_player,
but I really don't think this is a problem just wanted to mention it.

[commy2]

Same with the old one. In the end it's just a hacky work around. : /

[CorruptedHeart]

I assume this event is fired too late? Reloaded and can't be used in any way?

[commy2]

Reloaded is fired when the animation ended. too late...

I even thought about SoundPlayed event handler, but the only noise the player makes that it can't pick up is reloading it seems ...

[commy2]

Should be good now.

Question: Do we want this as general canInteractWith condition, or would we be better of by if we add it to Finger / Advanced Throwing / Wipe Goggles directly?

[jonpas]

I'd say general is fine.

[nicolasbadano]

@commy2, does this trigger when reloading vehicles?

[commy2]

It triggers whenever you press the reload key while being in the mission display.

[jonpas]

Merge @commy2 ?