Add arsenal zeus modules #4576
Merged
Add arsenal zeus modules #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bux
reviewed
Oct 20, 2016
addons/zeus/stringtable.xml
Outdated
| </Key> | ||
| <Key ID="STR_ACE_Zeus_moduleRemoveArsenal_displayName"> | ||
| <English>Remove arsenal from object</English> | ||
| <French>Retirer arsenal de l'object</French> |
There was a problem hiding this comment.
woops, I didn't save in tabler after I fixed that 👍
commy2
reviewed
Oct 20, 2016
addons/zeus/stringtable.xml
Outdated
| </Package> | ||
| </Project> | ||
| </Project> |
commy2
reviewed
Oct 20, 2016
| case (alive _object): { | ||
| [LSTRING(OnlyAlive)] call _fnc_errorAndClose; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
could this be changed to switch (true)? It already inverts the isPlayer.
Same below
|
lgtm aside from my two comments. haven't tried ingame though. |
Conflicts: addons/zeus/config.cpp
PabstMirror
reviewed
May 31, 2017
PabstMirror
approved these changes
May 31, 2017
|
question: Edit: just figured it out. access via action menu. |
|
@madpat3 please don't revive old tickets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: