Frag Superanal Cleanup #4803
Merged
Frag Superanal Cleanup #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
reviewed
Jan 4, 2017
| MUL(_cubic,(abs ((_boundingBox select 0) select _i)) + ((_boundingBox select 1) select _i)); | ||
| }; | ||
|
|
||
| if (_cubic <= 1) exitWith {}; |
There was a problem hiding this comment.
Not the best design, but it works since it's nested in a then block and not the forEach block.
| private _cubic = 1; | ||
| for "_i" from 0 to 2 do { | ||
| MUL(_cubic,(abs ((_boundingBox select 0) select _i)) + ((_boundingBox select 1) select _i)); | ||
| }; |
There was a problem hiding this comment.
This is pretty ugly. Should write the line 3 times like before and not do a for loop with constant from-to's.
|
I like this, because it has perf improvements and frags needs them badly. |
jonpas
added
kind/cleanup
PabstMirror
approved these changes
Feb 10, 2017
Merged
thojkooi
pushed a commit
that referenced
this pull request
Mar 13, 2017
* Minimal frag cleanup * Why did this even happen in the first place Conflicts: addons/frag/functions/fnc_frago.sqf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: