Cache Nametags onDraw3D flags. #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bux
reviewed
Jan 23, 2017
| @@ -0,0 +1,64 @@ | |||
| /* | |||
| * Author: <N/A> | |||
There was a problem hiding this comment.
|
|
|
I left the author from fnc_onDraw3D becaus I only copied stuff. I also
don't know who that N/A guy is.. He likes negative arrays thats for sure.
Well commy.. Then better make it official.. If its there people gonna use
it.
|
|
Can't avoid people using internals, but I can shift the blame on them if something breaks in good conscience. Doesn't help the end user, but I can sleep well at night. |
PabstMirror
approved these changes
Feb 4, 2017
|
@dedmen - looks good, I pushed some minor changes:
|
thojkooi
pushed a commit
that referenced
this pull request
Mar 13, 2017
* Cache Nametag flags * Remove unused privates * Fix fading, cursorOnly mode, improve cache reset * Fix header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cache the Nametag Flags and _maxDistance for 2 seconds instead of reparsing them every Frame.
This will take about 0.0621ms of load from eachFrame and cache it.
After caching the load will be about 0.0323ms per frame.
0.03ms improvement call me crazy if you want.
This will also remove the unused privates from fnc_onDraw3d.
This will create lag from changing Nametag settings to them being visible. Sadly cachedCall can only use 1 Event and I used
cba_events_visionModeEventto be also able to cache the _maxDistance variable.Calculating the _maxDistance variable takes 0.0267 ms so it's very worthwhile to be cached.