AdvFatigue - Fix unarmed sprint->prone + minor perf improvments #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
added
kind/bug-fix
commy2
reviewed
Feb 11, 2017
| vestContainer _unit, | ||
| backpackContainer _unit | ||
| ]; | ||
| private _gearMass = ((_unit getVariable [QEGVAR(movement,totalLoad), loadAbs _unit]) / 22.046) * GVAR(loadFactor); |
There was a problem hiding this comment.
Does this mean that fatigue requires movement now?
There was a problem hiding this comment.
Will fallback to just loadAbs _unit from the getVar
| @@ -21,6 +21,7 @@ private _duty = 1; | |||
| private _animType = _animName select [1, 3]; | |||
|
|
|||
| GVAR(isSwimming) = false; | |||
| GVAR(isProne) = (stance _unit) == "PRONE"; | |||
There was a problem hiding this comment.
Might as well use isEqualTo then.
|
Moved this to 3.10 milestone. We can potentially move to this to a 3.9.2 milestone if we need another patch or 3.10 takes a while longer. |
BaerMitUmlaut
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4880 - Adds
GVAR(isProne)which is set in getAnimDutyMinor performance improvements;
main one is setting total virtual load in movement (on
loadoutEH) so we can skip forEach loop