Medical/Repair 3den Toolbox State Fix (Bug fix for #4902)

[AACO]

Simple fix to store the toolbox state on the control level, instead of the missionNamespace level.

Resolves #4902

[commy2]

Why does this exist in the first place?

[PabstMirror]

That's how BIS does attributes:

class Rank: Toolbox {
    attributeLoad = "(_this controlsGroupCtrl 100) lbsetcursel (['private','corporal','sergeant','lieutenant','captain','major','colonel'] find _value);";
    attributeSave = "['private','corporal','sergeant','lieutenant','captain','major','colonel'] select (missionnamespace getvariable ['Rank_value',0]);";
    class Controls: Controls {
        class Value: Value {
            tooltips[] = {"Private", "Corporal", "Sergeant", "Lieutenant", "Captain", "Major", "Colonel"};
            onToolboxSelChanged = "missionnamespace setvariable ['Rank_value',_this select 1];";
        };
    };
};

Does rank have the same issue as ace's medic setting?

[commy2]

Storing this on the control seems really pointless. The control itself already has a state. I'm not sure this fix is correct.

[AACO]

If we use a default value of 0 we can probably get away with just using the toolbox state, otherwise it'd always save to the SQM, albeit it'd be the correct value.

[AACO]

@PabstMirror to your point about the rank module, I'm really not sure. The rank (and stance) toolboxes are stored as bonafide unit attributes, so I'm going to speculate and say BI is cheating and treats those slightly differently.

[PabstMirror]

Talking with @AACO - The way BIS does rank must use some special engine stuff as it works fine.

The current code's problem is using ace_isMedic_temp
It was only being changed on toolBoxChange, but not on load.
So opening and saving the attirbutes could change the value to the last settting.

[commy2]

The way BIS does rank must use some special engine stuff as it works fine.

:\