Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbags surfaces update #4971

Merged
merged 7 commits into from
Mar 15, 2017
Merged

Sandbags surfaces update #4971

merged 7 commits into from
Mar 15, 2017

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Mar 5, 2017

When merged this pull request will:

  • Add Tanoa surfaces support to Sandbags
  • Check height above terrain, if more than 0.05 disallow sandbags (when on buildings and similar)
  • Check if in water (ATL is negative during shallow swimmable water for some reason)
  • Use private keyword

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Mar 5, 2017
@jonpas jonpas added this to the 3.9.1 milestone Mar 5, 2017
@PabstMirror
Copy link
Contributor

@jonpas
Copy link
Member Author

jonpas commented Mar 5, 2017

Oh, didn't even realize there is a function that's exactly the same. I'll move it to common even.

@jonpas jonpas removed the status/WIP label Mar 6, 2017
@PabstMirror
Copy link
Contributor

Can build trench on stratis runway
surfaceType = "#GdtStratisConcrete"; CfgSurface -> concrete has dust of 0.15

Maybe we should keep the blacklist and just use the dust as a backup for external maps?
Or tweak dust cutoff?

@nateberkopec
Copy link

I have a crapton of mods/terrains loaded, noticing lots of concrete surfaces use 0.15 for dust. XCam-Taunus appears to use 0.15 for many of their road surfaces as well.

@jonpas
Copy link
Member Author

jonpas commented Mar 7, 2017

Will look at it and possibly just keep dust as fall-back if higher value will cause other problems.

@jonpas
Copy link
Member Author

jonpas commented Mar 11, 2017

Changed to fall-back for dust, as it does not work as expected for some cases.

@thojkooi thojkooi modified the milestones: 3.9.1, 3.10.0 Mar 13, 2017
@PabstMirror PabstMirror merged commit b31abee into master Mar 15, 2017
@PabstMirror PabstMirror deleted the sandbagsImprov branch March 15, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants