Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookoff desynch #4990

Merged
merged 3 commits into from
Mar 15, 2017
Merged

Fix cookoff desynch #4990

merged 3 commits into from
Mar 15, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 14, 2017

When merged this pull request will:

Randomness would be calculated on every machine, but only vehicle explosion and sound are done by the server. Smoke, light and fire sfx are done by each client.

Randomness would be calculated on every machine, but only vehicle explosion and sound are done by the server. Smoke, light and fire sfx are done by each client.
@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Mar 14, 2017
@commy2 commy2 added this to the 3.9.1 milestone Mar 14, 2017
@commy2 commy2 self-assigned this Mar 14, 2017
@commy2 commy2 changed the base branch from master to release-v3.9.1 March 14, 2017 09:15
@commy2 commy2 changed the base branch from release-v3.9.1 to master March 14, 2017 09:16
@commy2 commy2 changed the base branch from master to release-v3.9.1 March 14, 2017 09:17
@commy2 commy2 changed the base branch from release-v3.9.1 to master March 14, 2017 09:19
@654wak654
Copy link
Contributor

Q: Could a better solution be to calculate and broadcast a number from a single machine? Is it not worth the traffic?

@commy2
Copy link
Contributor Author

commy2 commented Mar 14, 2017

That would be the full solution without having to sacrifice any functionality (randomness), but I think it would require a lot of rewriting.

@bux bux merged commit 70b9f6f into master Mar 15, 2017
@bux bux deleted the fix-cookoff-desynch branch March 15, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookoff sound and visuals desynchronize
5 participants