Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French loc improvement #5017

Merged
merged 6 commits into from
Mar 25, 2017
Merged

French loc improvement #5017

merged 6 commits into from
Mar 25, 2017

Conversation

11RDP-LoupVert
Copy link
Contributor

@11RDP-LoupVert 11RDP-LoupVert commented Mar 22, 2017

(French) text as it is clutters the interface interface, making it
uneasy for medic to use the it smoothly.

Hopefully suggested changes fixes that.

There were a few typos and, in my opinion, unaccurate or missing
translation.
Based on French Army Field Manual, actual paramedical personnel and past
work on XMedSys.

When merged this pull request will:

  • Improve Medical usability in French version

(French) text as it is clutters the interface interface, making it
uneasy for medic to use the it smoothly.
https://i.gyazo.com/8d7a5bb2f15dd1332cec36f2eef510c8.png

Hopefully suggested changes fixes that.

There were a few typos and, in my opinion, unaccurate or missing
translation.
Based on French Army Field Manual, actual paramedical personnel and past
work on XMedSys.
@jonpas jonpas added kind/translation Release Notes: **TRANSLATIONS:** kind/enhancement Release Notes: **IMPROVED:** labels Mar 22, 2017
@jonpas jonpas added this to the 3.10.0 milestone Mar 22, 2017
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has to use 4 spaces for indentation, not tabs.

@11RDP-LoupVert
Copy link
Contributor Author

How can I fix that Jon?

@jonpas
Copy link
Member

jonpas commented Mar 22, 2017

Your editor has to be changed to use spaces instead of tabs, then you have to mass convert it back (as your commit converts everything to tabs).

@jonpas
Copy link
Member

jonpas commented Mar 22, 2017

@alganthe could we get you to take a quick look at this?

@alganthe
Copy link
Contributor

alganthe commented Mar 22, 2017

French is quite verbose, the best way to avoid that issue is to use the line display instead of the circular one.
There's also the option to remove the verbs and simply add the name of the item that is to be used, it may lead to confusion.

This solution fixes the result of the issue without fixing the root cause (tho the translation is on point), the menu simply currently doesn't handle that many items without text overlapping or reading issues.

Selectioner -> Sélectionner
Removes a duplicate entry, didn't saw first time
@jonpas
Copy link
Member

jonpas commented Mar 23, 2017

Doesn't fix the root issue, but improves translations by shortening them and keeping them on point (alganthe's words), I'd say fine to merge.

@PabstMirror PabstMirror merged commit fc860e7 into acemod:master Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants