Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionals moved into launchable mod folders #5038

Merged
merged 5 commits into from
Dec 31, 2017
Merged

Optionals moved into launchable mod folders #5038

merged 5 commits into from
Dec 31, 2017

Conversation

john681611
Copy link
Contributor

@john681611 john681611 commented Mar 26, 2017

When merged this pull request will:

@thojkooi
Copy link
Contributor

If we wish to go down this road, optionals should probably become seperate release packages, like we have done with the RHS compats on Steam.

I'm not sure having a bunch of @* directories in the optionals folder is desirable, expect for maybe the default Arma3 launcher. I don't see it gaining us much, but I am happy for this to be discussed further.

@john681611
Copy link
Contributor Author

This does not stop the separate packages on steam at all. The @ symbol isn't required it works without (I've added it so it works with publish). For those we decide not to publish to the variety of locations it will give players nice prepacked mods which means its less work for players even if they don't use the vanilla launcher.

@bux
Copy link
Member

bux commented Mar 27, 2017

TBH I'd like to see the optionals moved to separate repos.

@Dystopian
Copy link
Contributor

I vote for this. Managing optionals on every update is annoying.

@commy2 commy2 added this to the 3.12.0 milestone Dec 11, 2017
@jonpas
Copy link
Member

jonpas commented Dec 12, 2017

Let's do this for 3.13.0 then if no other concerns are found. Don't want to break people's setups (especially where automated) shortly before release.

@jonpas jonpas modified the milestones: 3.12.0, 3.13.0 Dec 12, 2017
@john681611
Copy link
Contributor Author

*rises from grave
Any work needed to be done on this?

@Dystopian
Copy link
Contributor

no john681611, waiting for 3.13

@jonpas
Copy link
Member

jonpas commented Dec 15, 2017

@john681611 as @Dystopian said, no, it looks good, but we want to make doubly sure nothing will break with it when we want to release, and also warn people in advance that this will change.

@commy2
Copy link
Contributor

commy2 commented Dec 31, 2017

Merge now?

@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.1 Dec 31, 2017
@PabstMirror PabstMirror merged commit 13be39d into acemod:master Dec 31, 2017
@john681611 john681611 deleted the launchableOptionals branch January 1, 2018 08:41
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Optionals moved into launchable mod folders
when using make.py

* added '@' prefix

* Simplify publish.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants