Use setShotParents in Advanced Throwing #5052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
added
kind/enhancement
|
Works fine locally. @rebelvg feel free to test. |
PabstMirror
approved these changes
Apr 3, 2017
|
@jonpas Made a few tests on the dedicated server with a friend. It works properly in the singleplayer, but in the multiplayer instigator is never set for some reason. When someone else picks up grenade in the multiplayer and it explodes in their hands - both shooter and instigator are null. If he throws it, he's only set as shooter, instigator is null. Probably some locality issue, but as I see you make a server event and setShotParents is server only so that should work properly. Not sure what's wrong. |
|
Must be that bug with the command then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Todo: