Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tagging model cache #5055

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Fix tagging model cache #5055

merged 1 commit into from
Apr 11, 2017

Conversation

PabstMirror
Copy link
Contributor

  • postInit wasn't saving p3d name to cache (wrong index)
  • other functions had inverted logic for exitWith (so it still worked)
  • config class isn't used, so just save bool

Could possibly cause array bounds error if a building had an odd model path (see #5035)

 7:25:43 Error in expression <aticModels setVariable [toLower (_array select ((count _array) - 2)), _cfgClass]>
 7:25:43   Error position: <select ((count _array) - 2)), _cfgClass]>
 7:25:43   Error Zero divisor

If array only had 1 element you could get something like ["x"] select -1

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Apr 3, 2017
@PabstMirror PabstMirror added this to the 3.10.0 milestone Apr 3, 2017
@commy2
Copy link
Contributor

commy2 commented Apr 8, 2017

param can handle negative indices and reports default value or nil instead without error.

@PabstMirror
Copy link
Contributor Author

The problem was that the index was just wrong,
if model = "\A3\Structures_F\Ind\PowerLines\HighVoltageColumn_F.p3d";
it was picking PowerLines instead of the p3d filename.

@PabstMirror PabstMirror merged commit f44da35 into master Apr 11, 2017
@PabstMirror PabstMirror deleted the fixTaggingCache branch April 11, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants