Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle escape menu with toggle iteractMenu #5144

Merged
merged 4 commits into from
May 31, 2017
Merged

Handle escape menu with toggle iteractMenu #5144

merged 4 commits into from
May 31, 2017

Conversation

PabstMirror
Copy link
Contributor

Close #5136

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 10, 2017
@PabstMirror PabstMirror added this to the 3.10.0 milestone May 10, 2017
@rebelvg
Copy link
Contributor

rebelvg commented May 10, 2017 •
edited
Loading

Just tried this. Interaction with cursor on closes properly now, but interaction without curson still opens esc menu instead of closing.

@PabstMirror
Copy link
Contributor Author

This should work on both display options now.

There is a tiny-micro stutter when hitting escape because it partialy loads the escape menu before closing, not ideal but it's barley noticeable.

@rebelvg
Copy link
Contributor

rebelvg commented May 17, 2017

Yep, seems to work.
Strange behavior can be noticed when you open interaction with cursor and while it's open you try to open interaction without cursor. It will kinda close previous interaction but won't open other interaction and still have black overlay enabled with the cursor.

jonpas
jonpas reviewed May 31, 2017
View reviewed changes
addons/interact_menu/functions/fnc_handleEscapeMenu.sqf Outdated
@@ -0,0 +1,25 @@
/*
* Author: PabstMirror
* Handle the escape key being pressed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final dot.

@PabstMirror PabstMirror merged commit bdab342 into master May 31, 2017
@PabstMirror PabstMirror deleted the escapeToggle branch May 31, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @rebelvg @jonpas